| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Feb 2011 00:17:28 -0500 From: Ted Ts'o <tytso@....edu> To: Eric Sandeen <sandeen@...hat.com> Cc: ext4 development <linux-ext4@...r.kernel.org> Subject: Re: [PATCH] ext4: make grpinfo slab cache names static Thanks, added to the ext4 patch queue. -- Ted On Wed, Jan 19, 2011 at 02:42:33PM -0600, Eric Sandeen wrote: > In 2.6.37 I was running into oopses with repeated module > loads & unloads. I tracked this down to: > > fb1813f4 ext4: use dedicated slab caches for group_info structures > > (this was in addition to the features advert unload problem) > > The kstrdup & subsequent kfree of the cache name was causing > a double free. In slub, at least, if I read it right it allocates > & frees the name itself, slab seems to do something different... > so in slub I think we were leaking -our- cachep->name, and double > freeing the one allocated by slub. > > After getting lost in slab/slub/slob a bit, I just looked at other > sized-caches that get allocated. jbd2, biovec, sgpool all do it > more or less the way jbd2 does. Below patch follows the jbd2 > method of dynamically allocating a cache at mount time from > a list of static names. > > (This might also possibly fix a race creating the caches with > parallel mounts running). > > Signed-off-by: Eric Sandeen <sandeen@...hat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists