linux-ext4 - Re: [PATCH] e2fsprogs: reserving code points for new ext4 quota feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Feb 2011 13:45:27 -0700
From:	Andreas Dilger <adilger@...ger.ca>
To:	Aditya Kali <adityakali@...gle.com>
Cc:	Ted Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsprogs: reserving code points for new ext4 quota feature

On 2011-02-15, at 12:54, Aditya Kali wrote:
> This patch adds support for detecting the new 'quota' feature in ext4.
> The patch reserves code points for usr and group quota inodes and also
> for the feature flag EXT4_FEATURE_RO_COMPAT_QUOTA.
> 
> diff --git a/ext2ed/inode_com.c b/ext2ed/inode_com.c
> index 843286c..cf7083d 100644
> --- a/ext2ed/inode_com.c
> +++ b/ext2ed/inode_com.c
> @@ -222,12 +222,6 @@ void type_ext2_inode___show (char *command_line)
> 			case EXT2_ROOT_INO:
> 				wprintw (show_win,"Root inode - ");
> 				break;
> -			case EXT2_ACL_IDX_INO:
> -				wprintw (show_win,"ACL index inode - ");
> -				break;
> -			case EXT2_ACL_DATA_INO:
> -				wprintw (show_win,"ACL data inode - ");
> -				break;

Most of the patch looks OK, though I don't understand why these are removed, instead of replacing them with EXT2_GRP_QUOTA_INO and EXT2_USR_QUOTA_INO?

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html