linux-ext4 - Re: [PATCH] ext4: enable acls and user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110224114914.GD23042@quack.suse.cz>
Date:	Thu, 24 Feb 2011 12:49:14 +0100
From:	Jan Kara <jack@...e.cz>
To:	Ted Ts'o <tytso@....edu>
Cc:	Eric Sandeen <sandeen@...hat.com>, Jan Kara <jack@...e.cz>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: enable acls and user_xattr by default

On Wed 23-02-11 12:31:52, Ted Ts'o wrote:
> On Mon, Feb 21, 2011 at 11:10:16AM -0600, Eric Sandeen wrote:
> > 
> > Well, I did this initially because Ted & Andreas seemed to want it ;)
> > 
> > I think the idea is, we should move to deprecating and removing the options
> > altogether.  Is there any advantage to having them?  And the first step
> > to deprecating them might be to change the default.
> 
> Yeah, part of the whole goal is to reduce the number of mount options,
> since they have really gotten out of control.  Each mount option is
> another adds more to the test combinatorics nightmare.
  Yes, I definitely agree with this.

> So basically, the question is how much value does the mount option
> add?  In fact changing acl's on and off can in fact cause surprises,
> since the posix acl's are designed to be safe when going from the
> noacl->acl case.  That is, the additional information in the posix
> acl's are designed to take away rights, but not add access rights.
  I agree it may cause surprises although it's not true that ACL's remove
rights. Rather on contrary ACL's can only give additional rights (i.e. you
have 600 file + user foo can also read it) thus noacl->acl transition might
be insecure if you have some old unwanted ACL's pending.

> But that also means that if you have a file system that had ACL's to
> restrict access rights, and then you mount it without using the acl
> option, users who aren't supposed to have access to the file might
> find themselves with access.
  As I write above it's the other way around but that's not a point I would
be afraid about. It's more that admins might run without user_xattr and
ACL's e.g. because their arguably stupid audit app is not able to handle
them properly. Suddenly they become enabled because of the kernel change,
users, can set them, and later the admin finds things are broken. So I'd
at least warn that the default is changing if (no)acl,(no)user_xattr
options are not used during mount.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html