linux-ext4 - Re: [PATCH] ext4:Fix a bug in ext4_ext_fiemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Feb 2011 10:34:32 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	Dave Chinner <david@...morbit.com>
CC:	Yongqiang Yang <xiaoqiangnk@...il.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4:Fix a bug in ext4_ext_fiemap_cb().

On 02/23/2011 06:04 PM, Dave Chinner wrote:
> This sound sort of problem indicateѕ to me that we need a generic
> fiemap test in xfstests that exercises all these corner cases.
> Perhaps something similar to the way I tested all the
> XFS_IOC_ZERO_RANGE corner cases in test 242 by setting up all the
> different hole/delalloc/unwritten/allocated combinations using
> xfs_io and used the fiemap output as the golden output?
> 
> That would catch all of these problems in the different filesystems
> that implement fiemap and make sure we notice regressions pretty
> quickly.....
> 
> Cheers,
> 
> Dave.

Or, remove the "sync" calls from josef's fiemap tester:

        fiemap->fm_flags = FIEMAP_FLAG_SYNC;

More random but would quickly blow up I bet.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html