linux-ext4 - Re: [PATCH] ext4:Make FIEMAP and delayed allocation play well together.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5B306456-0ECB-481A-9AA5-FD04FC71C216@dilger.ca>
Date:	Sat, 26 Feb 2011 23:57:55 -0700
From:	Andreas Dilger <adilger@...ger.ca>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	linux-ext4@...r.kernel.org, sandeen@...hat.com
Subject: Re: [PATCH] ext4:Make FIEMAP and delayed allocation play well together.

On 2011-02-26, at 8:05 AM, Yongqiang Yang wrote:
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>

You can also add Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> @@ -3782,38 +3783,162 @@ static int ext4_ext_fiemap_cb(struct inode *inode, struct ext4_ext_path *path,
> 		       struct ext4_ext_cache *newex, struct ext4_extent *ex,
> 		       void *data)
> {
> 	if (newex->ec_start == 0) {
> +		pages = kmalloc(PAGE_SIZE, GFP_KERNEL);
> +		if (pages == NULL)
> +			return -EFAULT;

This should be -ENOMEM.

Cheers, Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html