linux-ext4 - Re: [PATCH V2] ext3: Always set dx_node's fake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110307162647.GB3663@quack.suse.cz>
Date:	Mon, 7 Mar 2011 17:26:47 +0100
From:	Jan Kara <jack@...e.cz>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Jan Kara <jack@...e.cz>, Lachlan McIlroy <lmcilroy@...hat.com>
Subject: Re: [PATCH V2] ext3: Always set dx_node's fake_dirent explicitly.

On Fri 04-03-11 16:04:08, Eric Sandeen wrote:
> (crossport of 1f7bebb9e911d870fa8f997ddff838e82b5715ea
> by Andreas Schlick <schlick@...abit.com>)
> 
> When ext3_dx_add_entry() has to split an index node, it has to ensure that
> name_len of dx_node's fake_dirent is also zero, because otherwise e2fsck
> won't recognise it as an intermediate htree node and consider the htree to
> be corrupted.
>     
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
  Thanks. Merged - and added CC to stable@...nel.org as Andreas suggested.

> While it's a simple one liner, this took me forever to (re-)find.
  I feel with you :).

								Honza
> 
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index b27ba71..75c968e 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -1540,8 +1540,8 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
>  			goto cleanup;
>  		node2 = (struct dx_node *)(bh2->b_data);
>  		entries2 = node2->entries;
> +		memset(&node2->fake, 0, sizeof(struct fake_dirent));
>  		node2->fake.rec_len = ext3_rec_len_to_disk(sb->s_blocksize);
> -		node2->fake.inode = 0;
>  		BUFFER_TRACE(frame->bh, "get_write_access");
>  		err = ext3_journal_get_write_access(handle, frame->bh);
>  		if (err)
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html