linux-ext4 - Re: [PATCH]: e2fsprogs m_* self tests no longer pass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6898685A-0ADF-4AF1-8823-E4663A32983D@whamcloud.com>
Date:	Tue, 22 Mar 2011 17:16:38 +0100
From:	Andreas Dilger <adilger@...mcloud.com>
To:	Ted Ts'o <tytso@....edu>
Cc:	Lukas Czerner <lczerner@...hat.com>,
	ext4 development <linux-ext4@...r.kernel.org>,
	Bruce Cassidy <bruce@...mcloud.com>
Subject: Re: [PATCH]: e2fsprogs m_* self tests no longer pass

On 2011-03-19, at 9:29 PM, Ted Ts'o wrote:
> On Tue, Mar 15, 2011 at 01:50:48PM -0600, Andreas Dilger wrote:
>> Only display the "Discarding device blocks:" status bar if discard
>> is actually implemented in the IO manager and in the kernel.
>> Otherwise, there is no correct test result that will work in all
>> environments.  I'd prefer not to print an error message for the
>> majority of devices that do not support discard, since this is
>> confusing.
> 
> I believe this should be fixed already by commit aa07cb79b0, which is
> in the e2fsprogs master and next branches.  Can you confirm?

It looks like it will do the same thing, though I don't know what the semantics are for doing a 0-length discard.  I'm reluctant to do an operation like this that may not have well-defined semantics (e.g. return EINVAL for this case).

My patch only does the requested discard, and checks the return of the first call.  It still makes sense to print an error for anything other than EXT2_ET_UNIMPLEMENTED instead of silently hiding the error.

Cheers, Andreas
--
Andreas Dilger 
Principal Engineer
Whamcloud, Inc.



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html