linux-ext4 - Re: [PATCH] ext4: don't kfree uninitialized s_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110322012705.GA3907@thunk.org>
Date:	Mon, 21 Mar 2011 21:27:05 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>, dame_eugene@...l.ru
Subject: Re: [PATCH] ext4: don't kfree uninitialized s_group_info members

On Thu, Mar 10, 2011 at 05:03:15PM -0600, Eric Sandeen wrote:
> Per kernel.org bugzilla #30872 we may call kfree on uninitialized
> members of the s_group_info array.  We can avoid this by kzalloc'ing
> the array, and only freeing them on the error path if they are
> non-zero.
> 
> This doesn't entirely solve the oops on mount if we fail down this
> path; failed_mount4: frees the sbi, for one, which gets referenced
> later in the failed mount paths - I haven't worked that out yet.
> 
> Reported-by: Eugene A. Shatokhin <dame_eugene@...l.ru>
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Added to the ext4 patch tree, although I've dropped the second patch
hunk, since it's OK to call kfree on a NULL pointers:

> @@ -2412,7 +2412,8 @@ err_freebuddy:
>  		kmem_cache_free(cachep, ext4_get_group_info(sb, i));
>  	i = num_meta_group_infos;
>  	while (i-- > 0)
> -		kfree(sbi->s_group_info[i]);
> +		if (sbi->s_group_info[i])
> +			kfree(sbi->s_group_info[i]);
>  	iput(sbi->s_buddy_cache);
>  err_freesgi:
>  	kfree(sbi->s_group_info);

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html