linux-ext4 - Re: [PATCH] ext3: skip orphan cleanup on rocompat fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=xJNKei5Q_kvEMQ6usLhE6jgy6pmbGBq93gALU@mail.gmail.com>
Date:	Thu, 24 Mar 2011 12:34:05 +0200
From:	Amir Goldstein <amir73il@...il.com>
To:	stable@...nel.org
Cc:	Theodore Tso <tytso@....edu>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext3: skip orphan cleanup on rocompat fs

Hi,

Please apply commit ce654b37 to any stable kernel out there.

The relevant ext4 patch is in Ted's tree and has not reached mainline yet.
Ted, can you please add CC: stable to my patch.

Thanks,
Amir.

On Mon, Feb 28, 2011 at 8:09 PM, Jan Kara <jack@...e.cz> wrote:
> On Sat 26-02-11 22:40:19, Amir Goldstein wrote:
>> Orphan cleanup is currently executed even on readonly mount.
>> It deletes inodes and frees blocks, which could be very bad for some
>> RO_COMPAT features, HAS_SNAPSHOT to name one.
>>
>> Now the damage is done, because current stock kernels may
>> corrupt future fs with readonly compatible features,
>> when doing orphan cleanup.
>>
>> This patch skips the orphan cleanup if readonly compatible features
>> would prevent the fs from being mounted (or remounted) readwrite.
>  Thanks Amir. I actually took the version Ted committed to ext4 and ported
> it for ext3. Anyway, the patch is in my tree.
>
>                                                                Honza
>
> --
> Jan Kara <jack@...e.cz>
> SUSE Labs, CR
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html