linux-ext4 - Re: [PATCH] ext4: Remove redundant check for first_not_zeroed in ext4_register_li

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2011 21:58:05 +0800
From:	Tao Ma <tm@....ma>
To:	Lukas Czerner <lczerner@...hat.com>
CC:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Remove redundant check for first_not_zeroed in
 ext4_register_li_request.

On 03/28/2011 08:41 PM, Lukas Czerner wrote:
> On Mon, 28 Mar 2011, Lukas Czerner wrote:
> 
>> On Mon, 28 Mar 2011, Tao Ma wrote:
>>
>>> From: Tao Ma <boyu.mt@...bao.com>
>>>
>>> We have checked first_not_zeroed == ngroups already above,
>>> so remove this redundant check.
>>>
>>> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
>>> ---
>>>  fs/ext4/super.c |    5 -----
>>>  1 files changed, 0 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>>> index 2d1378f..37448a7 100644
>>> --- a/fs/ext4/super.c
>>> +++ b/fs/ext4/super.c
>>> @@ -2953,11 +2953,6 @@ static int ext4_register_li_request(struct super_block *sb,
>>>  		return 0;
>>>  	}
>>>  
>>> -	if (first_not_zeroed == ngroups) {
>>> -		sbi->s_li_request = NULL;
>>> -		return 0;
>>> -	}
>>> -
>>>  	elr = ext4_li_request_new(sb, first_not_zeroed);
>>>  	if (!elr)
>>>  		return -ENOMEM;
>>>
>>
>> Patch looks good.
>>
>> Thanks!
>> -Lukas
> 
> Just one tiny thing, we do not even need to set
> sbi->s_li_request = NULL since it is NULL already and we check that
> in the beginning of the function.
yeah, another patch will be sent for this. thanks for the review. ;)

Regards,
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html