linux-ext4 - Re: [PATCH] ext4: Fix a double free in ext4_register_li

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1103281207100.4923@dhcp-27-109.brq.redhat.com>
Date:	Mon, 28 Mar 2011 12:08:04 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	Tao Ma <tm@....ma>
cc:	linux-ext4@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] ext4: Fix a double free in ext4_register_li_request.

On Mon, 28 Mar 2011, Tao Ma wrote:

> From: Tao Ma <boyu.mt@...bao.com>
> 
> In ext4_register_li_request, we malloc a ext4_li_request and
> inserts it into ext4_li_info->li_request_list. In case of any
> error later, we free it in the end. But if we have some error
> in ext4_run_lazyinit_thread, the whole li_request_list will be
> dropped and freed in it. So we will double free this ext4_li_request.
> 
> This patch just sets elr to NULL after it is inserted to the list
> so that the latter kfree won't double free it.
> 
> Cc: stable@...nel.org
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
> ---
>  fs/ext4/super.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 22546ad..2d1378f 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2975,6 +2975,12 @@ static int ext4_register_li_request(struct super_block *sb,
>  	mutex_unlock(&ext4_li_info->li_list_mtx);
>  
>  	sbi->s_li_request = elr;
> +	/*
> +	 * set elr to NULL here since it has been inserted to
> +	 * the request_list and the removal and free of it is
> +	 * handled by ext4_clear_request_list from now on.
> +	 */
> +	elr = NULL;
>  
>  	if (!(ext4_li_info->li_state & EXT4_LAZYINIT_RUNNING)) {
>  		ret = ext4_run_lazyinit_thread();
> 

Good catch. Thanks, the patch looks good.

-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html