lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 4 Apr 2011 12:36:34 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Zhu Yanhai <zhu.yanhai@...il.com>
Cc:	linux-ext4@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kara <jack@...e.cz>, Zhu Yanhai <gaoyang.zyh@...bao.com>
Subject: Re: [PATCH] jbd2: Move bdget out of critical section

On Sat, Apr 02, 2011 at 05:01:16PM +0800, Zhu Yanhai wrote:
> bdget() should not be called when we hold spinlocks since
> it might sleep.
> 
> Signed-off-by: Zhu Yanhai <gaoyang.zyh@...bao.com>

I've added the patch to the patch queue.  Technically we should never
have a problem, though, since we only use this for the journal inode,
which is not going to be a fresly created inode.  So I don't think we
should ever hit the paths that will result in the kernel sleeping.
But I agree it's better to move it out, if for no other reason to make
life easier for static checkers.

          	       	     	       	    - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists