linux-ext4 - Re: [PATCH] ext4: Init timer earlier to avoid a kernel panic in __save_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110405235811.GK2832@thunk.org>
Date:	Tue, 5 Apr 2011 19:58:11 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Tao Ma <tm@....ma>
Cc:	linux-ext4@...r.kernel.org, sliedes@...hut.fi
Subject: Re: [PATCH] ext4: Init timer earlier to avoid a kernel panic in
 __save_error_info.

On Tue, Mar 29, 2011 at 12:11:12PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@...bao.com>
> 
> During mount, when we fail to open journal inode or root inode, the
> __save_error_info will mod_timer. But actually s_err_report isn't
> initialized yet and the kernel oops. The detailed information can
> be found https://bugzilla.kernel.org/show_bug.cgi?id=32082.
> 
> The best way is to check whether the timer s_err_report is initialized
> or not. But it seems that in include/linux/timer.h, we can't find a
> good function to check the status of this timer, so this patch just
> move the initializtion of s_err_report earlier so that we can avoid
> the kernel panic. The corresponding del_timer is also added in the
> error path.
> 
> Reported-by: Sami Liedes <sliedes@...hut.fi>
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>

Thanks, I've added this patch to the ext4 patch queue.

	     	   	      	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html