| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Apr 2011 21:20:03 +0200 From: Bernd Schubert <bernd.schubert@...m.fraunhofer.de> To: Johann Lombardi <johann@...mcloud.com> CC: linux-ext4@...r.kernel.org, Andreas Dilger <adilger@...mcloud.com> Subject: Re: [PATCH] ext4: add support for multiple mount protection Hello Johann, > +/* > + * Default interval in seconds to update the MMP sequence number. > + */ > +#define EXT4_MMP_UPDATE_INTERVAL 1 this define is nowhere used (e2fsprogs already sets the update-interval in the superblock). And it is also too small, which may cause a huge performance issue (please remember my corresponding lustre bugzilla...). Once you are going to post the e2fsprogs patch, could you please also take care of the 2TiB mmp-block read limitation bug (please see another Lustre bugzilla )? It also would be nice to explain somewhere (and not hidden in the code) what is the difference between "update interval" and "check interval". For example something like this: The 'mmp update interval' is the frequency how often the mmp is is supposed to be written. Values smaller than 5s may reduce performance. The 'mmp check interval' is used to verify if the mmp block has been updated on the device. The value is updated based on the maximum time to write the mmp-block during an update-cycle. Its minimum is 5 * mmp-update-interval Thanks, Bernd -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists