linux-ext4 - Re: [PATCH REC 0/3] ext4:Factor common code from convert and split unwritten.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTim9okgKc1omQ5dAvTHDrhfA_bpODw@mail.gmail.com>
Date:	Thu, 14 Apr 2011 22:34:38 +0800
From:	Yongqiang Yang <xiaoqiangnk@...il.com>
To:	"Ted Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org, achender@...ux.vnet.ibm.com,
	cmm@...ibm.com
Subject: Re: [PATCH REC 0/3] ext4:Factor common code from convert and split unwritten.

On Thu, Apr 14, 2011 at 10:14 PM, Ted Ts'o <tytso@....edu> wrote:
> On Wed, Apr 13, 2011 at 10:40:48PM -0700, Yongqiang Yang wrote:
>> These patches factor common code from ext4_ext_convert_to_initialized() and
>> ext4_split_unwritten_extents(), so that extent-move-on-write in snapshot and
>> punch-hole can be built on the common code as well.
>>
>> ext4:Add a function merging extent right and left.
>> ext4:Add two functions splitting an extent.
>> ext4:Reimplement convert and split_unwritten.
>
> Hi Yongqiang,
>
> I'd like to hear back from Mingming and Allison about whether these
> patches conflict with their punch patches, since my understanding was
> they were planning on doing very similar things (and at least would be
> working in the very similar parts of the code).
>
> I agree that the extents code here could definitely use this cleanup,
> and I'm really glad that you worked on this; thank you!  I just want
> to make sure work you are doing is coordinated with the work that
> Allison and Mingming are working on.

I knew it and Mingming told me that common code should be factor out
in previous emails.  so I cced patches to Mingming and Allison.
extent-move-on-write in ext4-snapshots needs a function splitting an
initialized extent.

These patches indeed need advices, reviews  and even tests from
Mingming and Allison.

Thank you,
Yongqiang.
>
>                                                - Ted
>



-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html