linux-ext4 - Re: [patch v2 2/4] percpu_counter: delete dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110418001255.GA19243@thunk.org>
Date:	Sun, 17 Apr 2011 20:12:55 -0400
From:	Ted Ts'o <tytso@....edu>
To:	shaohua.li@...el.com
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	cl@...ux.com, tj@...nel.org, eric.dumazet@...il.com,
	linux-ext4@...r.kernel.org
Subject: Re: [patch v2 2/4] percpu_counter: delete dead code

I'll take care of merging this patch via the ext4 tree.

     	       	  	       	     - Ted

On Wed, Apr 13, 2011 at 03:57:17PM +0800, shaohua.li@...el.com wrote:
> percpu_counter_sum_positive never returns negative.
> 
> Signed-off-by: Shaohua Li <shaohua.li@...el.com>
> 
> ---
>  fs/ext4/balloc.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> Index: linux/fs/ext4/balloc.c
> ===================================================================
> --- linux.orig/fs/ext4/balloc.c	2011-04-12 16:22:59.000000000 +0800
> +++ linux/fs/ext4/balloc.c	2011-04-13 13:23:01.000000000 +0800
> @@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
>  						EXT4_FREEBLOCKS_WATERMARK) {
>  		free_blocks  = percpu_counter_sum_positive(fbc);
>  		dirty_blocks = percpu_counter_sum_positive(dbc);
> -		if (dirty_blocks < 0) {
> -			printk(KERN_CRIT "Dirty block accounting "
> -					"went wrong %lld\n",
> -					(long long)dirty_blocks);
> -		}
>  	}
>  	/* Check whether we have space after
>  	 * accounting for current dirty blocks & root reserved blocks.
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html