linux-ext4 - [Ext4 punch hole 3/6 v5] Ext4 Punch Hole Support: Clear Hole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4DAD3CF3.1030309@linux.vnet.ibm.com>
Date:	Tue, 19 Apr 2011 00:42:43 -0700
From:	Allison Henderson <achender@...ux.vnet.ibm.com>
To:	linux-ext4@...r.kernel.org
Subject: [Ext4 punch hole 3/6 v5] Ext4 Punch Hole Support: Clear Hole

This patch adds routines needed to zero out the
unblock aligned data of the hole.

The existing ext4_block_truncate_page routine that
is used to zero out unblock aligned data from truncate
has been modified to accept a length parameter, and
renamed to ext4_block_zero_page_range.

The function can now be used to zero out the
head of a block, the tail of a block, or the middle
of a block.  The existing ext4_block_truncate_page
has now become a wrapper to this function

Signed-off-by: Allison Henderson <achender@...ibm.com>
---
:100644 100644 a256ba3... 6b64a79... M	fs/ext4/ext4.h
:100644 100644 ec890fd... 09fc53b... M	fs/ext4/inode.c
  fs/ext4/ext4.h  |    2 ++
  fs/ext4/inode.c |   33 +++++++++++++++++++++++++++++++--
  2 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index a256ba3..6b64a79 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1753,6 +1753,8 @@ extern int ext4_writepage_trans_blocks(struct 
inode *);
  extern int ext4_chunk_trans_blocks(struct inode *, int nrblocks);
  extern int ext4_block_truncate_page(handle_t *handle,
  		struct address_space *mapping, loff_t from);
+extern int ext4_block_zero_page_range(handle_t *handle,
+		struct address_space *mapping, loff_t from, loff_t length);
  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct 
vm_fault *vmf);
  extern qsize_t *ext4_get_reserved_space(struct inode *inode);
  extern void ext4_da_update_reserve_space(struct inode *inode,
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index ec890fd..09fc53b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3915,9 +3915,30 @@ void ext4_set_aops(struct inode *inode)
  int ext4_block_truncate_page(handle_t *handle,
  		struct address_space *mapping, loff_t from)
  {
+	unsigned offset = from & (PAGE_CACHE_SIZE-1);
+	unsigned length;
+	unsigned blocksize;
+	struct inode *inode = mapping->host;
+
+	blocksize = inode->i_sb->s_blocksize;
+	length = blocksize - (offset & (blocksize - 1));
+
+	return ext4_block_zero_page_range(handle, mapping, from, length);
+}
+
+/*
+ * ext4_block_zero_page_range() zeros out a mapping of length 'length'
+ * starting from file offset 'from'.  The range to be zero'd must
+ * be contained with in one block.  If the specified range exceeds
+ * the end of the block it will be shortened to end of the block
+ * that cooresponds to 'from'
+ */
+int ext4_block_zero_page_range(handle_t *handle,
+		struct address_space *mapping, loff_t from, loff_t length)
+{
  	ext4_fsblk_t index = from >> PAGE_CACHE_SHIFT;
  	unsigned offset = from & (PAGE_CACHE_SIZE-1);
-	unsigned blocksize, length, pos;
+	unsigned blocksize, max, pos;
  	ext4_lblk_t iblock;
  	struct inode *inode = mapping->host;
  	struct buffer_head *bh;
@@ -3930,7 +3951,15 @@ int ext4_block_truncate_page(handle_t *handle,
  		return -EINVAL;

  	blocksize = inode->i_sb->s_blocksize;
-	length = blocksize - (offset & (blocksize - 1));
+	max = blocksize - (offset & (blocksize - 1));
+
+	/*
+	 * correct length if it does not fall between
+	 * 'from' and the end of the block
+	 */
+	if (length > max || length < 0)
+		length = max;
+
  	iblock = index << (PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits);

  	if (!page_has_buffers(page))
-- 
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html