linux-ext4 - [PATCH 4/4] ext3: ensure fast symlinks are NUL-terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1303265260-9210-4-git-send-email-prasanna.panchamukhi@riverbed.com>
Date:	Tue, 19 Apr 2011 19:07:40 -0700
From:	prasanna.panchamukhi@...erbed.com
To:	prasanna.panchamukhi@...erbed.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Tweedie <sct@...hat.com>, linux-ext4@...r.kernel.org
Subject: [PATCH 4/4] ext3: ensure fast symlinks are NUL-terminated

From: Prasanna S. Panchamukhi <ppanchamukhi@...erbed.com>

Ensure fast symlink targets are NUL-terminated, even if corrupted
on-disk.

This patch has been back ported from upstream
commit b5ed3112b5f74c8ec1c7aa03a76c596635e85197.

Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Stephen Tweedie <sct@...hat.com>
Cc: linux-ext4@...r.kernel.org
Signed-off-by: Duane Griffin <duaneg@...da.com>
Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
BugID: 68873
Signed-off-by: Prasanna S. Panchamukhi <ppanchamukhi@...erbed.com>
---
 fs/ext3/inode.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 67d0af8..d669d78 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -36,6 +36,7 @@
 #include <linux/writeback.h>
 #include <linux/mpage.h>
 #include <linux/uio.h>
+#include <linux/namei.h>
 #include "xattr.h"
 #include "acl.h"
 
@@ -2481,9 +2482,11 @@ void ext3_read_inode(struct inode * inode)
 		inode->i_op = &ext3_dir_inode_operations;
 		inode->i_fop = &ext3_dir_operations;
 	} else if (S_ISLNK(inode->i_mode)) {
-		if (ext3_inode_is_fast_symlink(inode))
+		if (ext3_inode_is_fast_symlink(inode)) {
 			inode->i_op = &ext3_fast_symlink_inode_operations;
-		else {
+			nd_terminate_link(ei->i_data, inode->i_size,
+						      sizeof(ei->i_data) - 1);
+		} else {
 			inode->i_op = &ext3_symlink_inode_operations;
 			ext3_set_aops(inode);
 		}
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html