lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 20 Apr 2011 12:13:06 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Allison Henderson <achender@...ux.vnet.ibm.com>
Cc:	Yongqiang Yang <xiaoqiangnk@...il.com>, linux-ext4@...r.kernel.org,
	cmm@...ibm.com
Subject: Re: [PATCH RFC 2/3] ext4:Add two functions splitting an extent.

On 2011-04-20, at 11:21 AM, Allison Henderson wrote:
> I've been working on trying to get the punch hole patch to work with with these new changes, but it looks like some test cases are not passing at the moment, so I'm trying track down where the issues are.  I had to make some adjustments to this patch to fix one of the test cases.  Here is what I did:
> 
> ---
> :100644 100644 ee2dda3... c7d763d... M  fs/ext4/extents.c
> fs/ext4/extents.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ee2dda3..c7d763d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2717,12 +2717,12 @@ static int ext4_split_extent(handle_t *handle,
>        ee_len = ext4_ext_get_actual_len(ex);
>        uninitialized = ext4_ext_is_uninitialized(ex);
> 
> +       flags1 = flags;
> +       flags1 |= EXT4_GET_BLOCKS_PRE_IO;

Can you please use normal C style: "flags1 = flags | EXT4_GET_BLOCKS_PRE_IO;"


Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists