lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 23 Apr 2011 09:10:07 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Robin Dong <hao.bigrat@...il.com>
CC:	linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com>
Subject: Re: [PATCH] fix incorrect error-message of ext2

On 4/23/11 8:36 AM, Robin Dong wrote:
> From: Robin Dong <sanbai@...bao.com>
> 
> After "mkfs.ext2 -b 8192" on a new partition, I mount it with a error dmesg:
> "error: blocksize is too small"
> That's not correct.

Hi Robin -

Can you write a more descriptive changelog?

Imagine reading through git logs 2 years later, especially with --pretty=oneline.

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx fix incorrect error-message of ext2

would not be a very informative summary.

And the changelog itself says nothing about why the error is incorrect.

What was the device tested?  What is the pagesize of the system used?
Etc...

Maybe something like:

[PATCH] ext2: fix error msg when mounting fs with too-large blocksize

When ext2 mounts a filesystem, it attempts to set the block device
blocksize with a call to sb_set_blocksize, which can fail for
several reasons.  The current failure message in ext2 prints:

   EXT2-fs (loop1): error: blocksize is too small

which is not correct in all cases.  This can be demonstrated
by creating a filesystem with

   # mkfs.ext2 -b 8192

on a 4k page system, and attempting to mount it.

Change the error message to a more generic:

   EXT2-fs (loop1): bad blocksize 8192

to match the error message in ext3.

----

If the extra tests and message about hardware sector size are needed,
they probably should be added to ext3 as well.

In the testcase above, though, we just failed due to block size
vs. page size restrictions.

-Eric


> Signed-off-by: Robin Dong <sanbai@...bao.com>
> ---
>  fs/ext2/super.c |   16 +++++++++++++++-
>  1 files changed, 15 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 0a78dae..f3008c1 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -758,6 +758,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  	unsigned long def_mount_opts;
>  	long ret = -EINVAL;
>  	int blocksize = BLOCK_SIZE;
> +	int hblock;
>  	int db_count;
>  	int i, j;
>  	__le32 features;
> @@ -893,12 +894,25 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  		goto failed_mount;
>  	}
>  
> +	hblock = bdev_logical_block_size(sb->s_bdev);
>  	/* If the blocksize doesn't match, re-read the thing.. */
>  	if (sb->s_blocksize != blocksize) {
> +		/*
> +		 * Make sure the blocksize for the filesystem is larger
> +		 * than the hardware sectorsize for the machine.
> +		 */
> +		if (blocksize < hblock) {
> +			ext2_msg(sb, KERN_ERR,
> +				"error: fsblocksize %d too small for "
> +				"hardware sectorsize %d", blocksize, hblock);
> +			goto failed_mount;
> +		}
> +
>  		brelse(bh);
>  
>  		if (!sb_set_blocksize(sb, blocksize)) {
> -			ext2_msg(sb, KERN_ERR, "error: blocksize is too small");
> +			ext2_msg(sb, KERN_ERR,
> +				"error: bad blocksize %d", blocksize);


>  			goto failed_sbi;
>  		}
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists