lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4DB3CE9F.1020201@gmail.com> Date: Sun, 24 Apr 2011 15:17:51 +0800 From: Coly Li <colyli@...il.com> To: Robin Dong <sanbai@...bao.com> CC: linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext2: fix error msg when mounting fs with too-large blocksize On 2011年04月24日 14:36, Robin Dong Wrote: > From: Robin Dong <sanbai@...bao.com> > > When ext2 mounts a filesystem, it attempts to set the block device > blocksize with a call to sb_set_blocksize, which can fail for > several reasons. The current failure message in ext2 prints: > > EXT2-fs (loop1): error: blocksize is too small > > which is not correct in all cases. This can be demonstrated > by creating a filesystem with > > # mkfs.ext2 -b 8192 > > on a 4k page system, and attempting to mount it. > > Change the error message to a more generic: > > EXT2-fs (loop1): bad blocksize 8192 > > to match the error message in ext3. > Reviewed-by: Coly Li <bosong.ly@...bao.com> > Signed-off-by: Robin Dong <sanbai@...bao.com> > --- > fs/ext2/super.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index 0a78dae..1dd62ed 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -898,7 +898,8 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) > brelse(bh); > > if (!sb_set_blocksize(sb, blocksize)) { > - ext2_msg(sb, KERN_ERR, "error: blocksize is too small"); > + ext2_msg(sb, KERN_ERR, > + "error: bad blocksize %d", blocksize); > goto failed_sbi; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists