linux-ext4 - Re: ext4_put_super is not called during system shutdown or restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB5D715.3040809@redhat.com>
Date:	Mon, 25 Apr 2011 15:18:29 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Zhao Cai <zhaocai@...com>
CC:	Amir Goldstein <amir73il@...il.com>,
	ext4 mailing list <linux-ext4@...r.kernel.org>
Subject: Re: ext4_put_super is not called during system shutdown or restart

On 4/25/11 3:07 PM, Zhao Cai wrote:
> In that case, how to make sure all the jbd2 transactions are fininshed before reboot? is it ext4_freeze and jbd2_journal_flush?

the remount readonly path should do this, I think.

ext4_remount
	ext4_mark_recovery_complete
		jbd2_journal_lock_updates
		jbd2_journal_flush

-Eric

> Thanks.
> --
> All the best,
> 
> Zhao Cai
> 
> 
> On Apr 25, 2011, at 12:12 PM, Zhao Cai wrote:
> 
>> On Apr 25, 2011, at 12:10 PM, Eric Sandeen wrote:
>>
>>> On 4/25/11 11:05 AM, Zhao Cai wrote:
>>>> Sorry, my mistake. It happens only when ext4 is the root file system. 
>>>
>>> that makes sense, since root is never actually unmounted; it just goes to readonly.
>>>
>>> -Eric
>>
>> Thanks. That means it is designed to be like this!
>>
>>>> -Zhao
>>>>
>>>>
>>>> On Apr 25, 2011, at 11:02 AM, Amir Goldstein wrote:
>>>>
>>>>> On Monday, April 25, 2011, Eric Sandeen <sandeen@...hat.com> wrote:
>>>>>> On 4/24/11 11:12 PM, Zhao Cai wrote:
>>>>>>> I would appreciate if anyone can give me an answer. Is it designed to
>>>>>>> be like this?
>>>>>>>
>>>>>>> Detailed situation: The system is ubuntu 11.04 installed in VMware. I
>>>>>>> notice that ext4_put_super() is called when I unmount a non-root ext4
>>>>>>> partition. But it is not when I restart or shutdown the system.
>>>>>>
>>>>>> Even for a non-root filesystem?
>>>>>>
>>>>>> I don't know if ubuntu does anything special, but I would expect that during a system shutdown, non-root filesystems would be unmounted, and you'd get put_super called.  Unless the fs is busy and it can't be unmounted for some reason...
>>>>>
>>>>> This strangely reminds me of my report that xfstests sometimes fails
>>>>> to umount on Ubuntu 10.10.
>>>>> But I could be just trying to hold on to the hope of somebody else
>>>>> solving my problems...
>>>>>
>>>>>>
>>>>>> -Eric
>>>>>>
>>>>>>> Thanks。
>>>>>>>
>>>>>>> -- All the best,
>>>>>>>
>>>>>>> Zhao Cai
>>>>>>>
>>>>>>>
>>>>>>> -- To unsubscribe from this list: send the line "unsubscribe
>>>>>>> linux-ext4" in the body of a message to majordomo@...r.kernel.org
>>>>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>>>>
>>>>>> --
>>>>>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>>>>>> the body of a message to majordomo@...r.kernel.org
>>>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>>>>
>>>>
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>>> the body of a message to majordomo@...r.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html