linux-ext4 - Re: [PATCH] ext4: Don't set PageUptodate in ext4_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 May 2011 17:56:42 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Curt Wohlgemuth <curtw@...gle.com>
Cc:	linux-ext4@...r.kernel.org, jim@...ering.net, cmm@...ibm.com
Subject: Re: [PATCH] ext4: Don't set PageUptodate in ext4_end_bio()

On Fri, Apr 22, 2011 at 10:51:58AM -0700, Curt Wohlgemuth wrote:
> In the bio completion routine, we should not be setting
> PageUptodate at all -- it's set at sys_write() time, and is
> unaffected by success/failure of the write to disk.
> 
> This can cause a page corruption bug when
> 
>       block size < page size
> 
> if we have only written a single block -- we might end up
> setting the entire PageUptodate, which will cause subsequent
> reads to get bad data.
> 
> Signed-off-by: Curt Wohlgemuth <curtw@...gle.com>
> Reported-by: Jim Meyering <jim@...ering.net>
> Reported-by: Hugh Dickins <hughd@...gle.com>
> Cc: Mingming Cao <cmm@...ibm.com>

Thanks, I've added this to the ext4 tree.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html