linux-ext4 - Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110502145807.GA32155@redhat.com>
Date:	Mon, 2 May 2011 10:58:11 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Christoph Hellwig <hch@...radead.org>,
	device-mapper development <dm-devel@...hat.com>,
	Alasdair G Kergon <agk@...hat.com>, sandeen@...hat.com,
	DarkNovaNick@...il.com, linux-lvm@...hat.com,
	linux-ext4@...r.kernel.org
Subject: Re: do not disable ext4 discards on first discard failure? [was: Re:
 dm snapshot: ignore discards issued to the snapshot-origin target]

On Mon, May 02 2011 at 10:39am -0400,
Lukas Czerner <lczerner@...hat.com> wrote:

> On Mon, 2 May 2011, Martin K. Petersen wrote:
> 
> > >>>>> "Lukas" == Lukas Czerner <lczerner@...hat.com> writes:
> > 
> > Lukas> So I gave it a try. First of all the device composed of SSD and
> > Lukas> spinning disk does export discard_support information properly,
> > Lukas> however it also advertise discard_zeroes_data which is wrong and
> > Lukas> possibly dangerous and should be fixed!
> > 
> > I can't reproduce this here. If I mix discard and non-discard devices
> > things work correctly. discard_zeroes_data also gets cleared if I mix
> > discard-capable drives where one zeroes and one doesn't.
> > 
> > 
> 
> [root@...m ~]# hdparm -I /dev/sdb | grep -i trim
> [root@...m ~]# cat /sys/block/sdb/queue/discard_zeroes_data
> 0
> [root@...m ~]# hdparm -I /dev/sdd | grep -i trim
>            *    Data Set Management TRIM supported
>            *    Deterministic read after TRIM
> [root@...m ~]# cat /sys/block/sdd/queue/discard_zeroes_data 
> 1
> [root@...m ~]# pvcreate /dev/sdd1 
>   Physical volume "/dev/sdd1" successfully created
> [root@...m ~]# pvcreate /dev/sdb3 
>   Physical volume "/dev/sdb3" successfully created
> [root@...m ~]# vgcreate vg_test /dev/sdd1 /dev/sdb3 
>   Volume group "vg_test" successfully created
> [root@...m ~]# lvcreate -L 3500M vg_test
>   Logical volume "lvol0" created
> [root@...m ~]# ls -lah /dev/mapper/vg_test-lvol0 
> lrwxrwxrwx. 1 root root 7  2. kvě 10.30 /dev/mapper/vg_test-lvol0 -> ../dm-0
> [root@...m ~]# cat /sys/block/dm-0/queue/discard_zeroes_data 
> 1

Hmm, Strange considering DM just uses blk_stack_limits().

As Martin said, current blk_stack_limits() code is fine:
t->discard_zeroes_data &= b->discard_zeroes_data;

> So I assume it got fixes just recently ?. I'll give it a try with the
> up-to-date kernel.

Hasn't changed at all since it was introduced:
98262f2 v2.6.33-rc1 block: Allow devices to indicate whether discarded blocks are zeroed
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html