linux-ext4 - Re: [dm-devel] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DC18427.6050400@redhat.com>
Date:	Wed, 04 May 2011 11:51:51 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Ted Ts'o" <tytso@....edu>
CC:	Christoph Hellwig <hch@...radead.org>,
	Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: [dm-devel] do not disable ext4 discards on first discard failure?
 [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]

On 5/4/11 11:33 AM, Ted Ts'o wrote:
> On Fri, Apr 29, 2011 at 09:28:51AM -0500, Eric Sandeen wrote:
>> On 4/29/11 7:29 AM, Christoph Hellwig wrote:
>>> FYI, that disable discard on failure seems to be an ext4 special and no
>>> one else picked up that stupid idea.  If ext4 wants to misbehave for
>>> that just let them..
>>
>> It was my "stupid idea," and I'm ok with reverting it ;)
> 
> I think I forgot to send the patch out, but it's been reverted in the
> ext4 master branch, commit id: d9f34504e695.  It's more than a revert,
> actually, since I also dropped error checking for FITRIM.  Otherwise
> an attempt to use FITRIM would stop after hitting the first dm region
> that didn't support discards.
> 
> 						- Ted

The xfs must-be-posted-and-reviewed-before-commit policy would be helpful here, I think.

If it's understood and agreed upon, people will get more diligent about review, and it'll be easier to remember to send the patch out - because it's policy.

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html