linux-ext4 - Re: [PATCH] jbd/jbd2: remove obsolete summarise_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2011 18:14:54 +0200
From:	Jan Kara <jack@...e.cz>
To:	Tao Ma <tm@....ma>
Cc:	linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] jbd/jbd2: remove obsolete summarise_journal_usage.

On Thu 05-05-11 23:54:19, Tao Ma wrote:
> From: Tao Ma <boyu.mt@...bao.com>
> 
> summarise_journal_usage seems to be obsolete for a long time,
> so remove it.
  Yes. Added to my tree. Thanks.

								Honza
> 
> Cc: Jan Kara <jack@...e.cz>
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
> ---
>  fs/jbd/commit.c  |    6 ------
>  fs/jbd2/commit.c |    6 ------
>  2 files changed, 0 insertions(+), 12 deletions(-)
> 
> diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c
> index 69b1804..9cbf9e4 100644
> --- a/fs/jbd/commit.c
> +++ b/fs/jbd/commit.c
> @@ -302,12 +302,6 @@ void journal_commit_transaction(journal_t *journal)
>  	 * all outstanding updates to complete.
>  	 */
>  
> -#ifdef COMMIT_STATS
> -	spin_lock(&journal->j_list_lock);
> -	summarise_journal_usage(journal);
> -	spin_unlock(&journal->j_list_lock);
> -#endif
> -
>  	/* Do we need to erase the effects of a prior journal_flush? */
>  	if (journal->j_flags & JFS_FLUSHED) {
>  		jbd_debug(3, "super block updated\n");
> diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
> index 6e28000..29148a8 100644
> --- a/fs/jbd2/commit.c
> +++ b/fs/jbd2/commit.c
> @@ -338,12 +338,6 @@ void jbd2_journal_commit_transaction(journal_t *journal)
>  	 * all outstanding updates to complete.
>  	 */
>  
> -#ifdef COMMIT_STATS
> -	spin_lock(&journal->j_list_lock);
> -	summarise_journal_usage(journal);
> -	spin_unlock(&journal->j_list_lock);
> -#endif
> -
>  	/* Do we need to erase the effects of a prior jbd2_journal_flush? */
>  	if (journal->j_flags & JBD2_FLUSHED) {
>  		jbd_debug(3, "super block updated\n");
> -- 
> 1.7.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html