[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 5 May 2011 13:23:21 +0200
From: Jan Kara <jack@...e.cz>
To: Robin Dong <hao.bigrat@...il.com>
Cc: linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com>,
Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext2: fix error msg when mounting fs with too-large
blocksize
On Thu 05-05-11 10:44:04, Robin Dong wrote:
> When ext2 mounts a filesystem, it attempts to set the block device
> blocksize with a call to sb_set_blocksize, which can fail for
> several reasons. The current failure message in ext2 prints:
>
> EXT2-fs (loop1): error: blocksize is too small
>
> which is not correct in all cases. This can be demonstrated
> by creating a filesystem with
>
> # mkfs.ext2 -b 8192
>
> on a 4k page system, and attempting to mount it.
>
> Change the error message to a more generic:
>
> EXT2-fs (loop1): bad blocksize 8192
>
> to match the error message in ext3.
>
> Signed-off-by: Robin Dong <sanbai@...bao.com>
> Reviewed-by: Coly Li <bosong.ly@...bao.com>
> Reviewed-by: Eric Sandeen <sandeen@...hat.com>
Thanks. Merged into my tree.
Honza
--
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists