linux-ext4 - Re: [PATCH] ext4: remove redundant 'extern' keyword for function-definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <811F6CB9-D7EB-41BA-B403-6530A5BF7234@mit.edu>
Date:	Fri, 6 May 2011 06:50:12 -0400
From:	Theodore Tso <tytso@....EDU>
To:	Robin Dong <hao.bigrat@...il.com>
Cc:	linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com>
Subject: Re: [PATCH] ext4: remove redundant 'extern' keyword for function-definition

I don't really see the point to removing redundant keywords
like this.   To my mind, it's like fixing whitespaces.   If we are 
making changes to that part of the code, it's good to fix it,
and I'd rather not introduce such things in new code, but
as far as fixing code like this, i don't think an extra "extern"
is that harmful that it's worth fixing up.

What do other people think?

-- Ted


On May 6, 2011, at 4:19 AM, Robin Dong wrote:

> Signed-off-by: Robin Dong <sanbai@...bao.com>
> ---
> fs/ext4/ialloc.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 21bb2f6..ace7aef 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1235,7 +1235,7 @@ unsigned long ext4_count_dirs(struct super_block * sb)
>  * inode allocation from the current group, so we take alloc_sem lock, to
>  * block ext4_claim_inode until we are finished.
>  */
> -extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
> +int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
> 				 int barrier)
> {
> 	struct ext4_group_info *grp = ext4_get_group_info(sb, group);
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html