linux-ext4 - Re: [PATCH] ext4: Use EXT4FS_DEBUG instead of EXT4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110509015506.GD4138@thunk.org>
Date:	Sun, 8 May 2011 21:55:06 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Tao Ma <tm@....ma>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Use EXT4FS_DEBUG instead of EXT4_DEBUG in fsync.c

On Mon, Mar 28, 2011 at 11:41:12PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@...bao.com>
> 
> We have EXT4FS_DEBUG for some old debug and CONFIG_EXT4_DEBUG
> for the new mballoc debug, but there isn't any EXT4_DEBUG.
> 
> As CONFIG_EXT4_DEBUG seems to be only used in mballoc, use
> EXT4FS_DEBUG in fsync.c.
> 
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>

It doesn't really matter; although I'm including this patch in the
ext4 tree for consistency's sake.  The whole point of the #ifdef's is
to disable the debugging code.  In general you don't want to enable
all of the code protected by EXT4FS_DEBUG at the same time.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html