linux-ext4 - Re: [PATCH] mke2fs: Avoid segmentation fault in ext2fs_alloc_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1105091743330.3694@dhcp-27-109.brq.redhat.com>
Date:	Mon, 9 May 2011 17:45:28 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	Tao Ma <tm@....ma>
cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] mke2fs: Avoid segmentation fault in
 ext2fs_alloc_generic_bmap.

On Mon, 9 May 2011, Tao Ma wrote:

> From: Tao Ma <boyu.mt@...bao.com>
> 
> In case of error, ext2fs_alloc_generic_bmap free the memory
> in the wrong order. So change it to free description first
> and then the bitmap.
> 
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
> ---
>  lib/ext2fs/gen_bitmap64.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/ext2fs/gen_bitmap64.c b/lib/ext2fs/gen_bitmap64.c
> index df095ac..8b9e4c5 100644
> --- a/lib/ext2fs/gen_bitmap64.c
> +++ b/lib/ext2fs/gen_bitmap64.c
> @@ -129,8 +129,8 @@ errcode_t ext2fs_alloc_generic_bmap(ext2_filsys fs, errcode_t magic,
>  
>  	retval = bitmap->bitmap_ops->new_bmap(fs, bitmap);
>  	if (retval) {
> -		ext2fs_free_mem(&bitmap);
>  		ext2fs_free_mem(&bitmap->description);
> +		ext2fs_free_mem(&bitmap);
>  		return retval;
>  	}

I have actually sent the same patch a while ago:

http://www.spinics.net/lists/linux-ext4/msg23763.html

but Ted have not picked up this yet.

-Lukas

>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html