linux-ext4 - Re: [PATCH] jbd2: only print the debugging information for tid wraparound once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <A44F9507-B35B-4E9A-BB76-CA6CFA95BE2C@dilger.ca>
Date:	Mon, 9 May 2011 16:52:57 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] jbd2: only print the debugging information for tid wraparound once

On May 8, 2011, at 17:38, Theodore Ts'o wrote:
> If we somehow wrap, we don't want to keep printing the warning message
> over and over again.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>

Acked-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/jbd2/journal.c |    9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 8c10004..cd2d341 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -500,10 +500,11 @@ int __jbd2_log_start_commit(journal_t *journal, tid_t target)
> 		/* This should never happen, but if it does, preserve
> 		   the evidence before kjournald goes into a loop and
> 		   increments j_commit_sequence beyond all recognition. */
> -		WARN(1, "jbd: bad log_start_commit: %u %u %u %u\n",
> -		     journal->j_commit_request, journal->j_commit_sequence,
> -		     target, journal->j_running_transaction ? 
> -		     journal->j_running_transaction->t_tid : 0);
> +		WARN_ONCE(1, "jbd: bad log_start_commit: %u %u %u %u\n",
> +			  journal->j_commit_request,
> +			  journal->j_commit_sequence,
> +			  target, journal->j_running_transaction ? 
> +			  journal->j_running_transaction->t_tid : 0);
> 	return 0;
> }
> 
> -- 
> 1.7.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html