linux-ext4 - Re: [PATCH 0/3] Rewrite ext4_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinLxrarrb0W2eA-=ZM=2LbA33qiZA@mail.gmail.com>
Date:	Wed, 11 May 2011 10:33:17 +0300
From:	"Amir G." <amir73il@...rs.sourceforge.net>
To:	Jan Kara <jack@...e.cz>
Cc:	Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 0/3] Rewrite ext4_page_mkwrite, fix fs freezing

Hi Jan,

Can you provide a bit of a wider scope review of how this related to
the work on stable pages.
For example, when to the pages get unlocked?
If the pages supposed to be stable during writeback, how is this related to
returning locked pages from page_mkwrite?
Is the page going to stay locked until writeback?
Do I understand correctly that a page will be marked read-only after
writeback completes, so page_mkwrite will be called again on next write?

Thanks,
Amir.

On Wed, May 11, 2011 at 1:29 AM, Jan Kara <jack@...e.cz> wrote:
>
>  Hi,
>
>  following three patches reimplement ext4_page_mkwrite() so that it returns
> locked pages (which is necessary for stable pages work and also for fixing of
> freezing code). As a bonus we also avoid taking i_alloc_sem as it's not
> necessary and use generic block_page_mkwrite() helper. The common delalloc
> path should be more straightforward now.
>
> The last patch in the series blocks mmaped writes on frozen filesystem which
> is simple to do now.
>
> I've tested these patches by xfstests and also running fsx-linux for all
> modes - delalloc, nodelalloc (data=writeback), nodelalloc (data=ordered),
> nodelalloc (data=journal).
>
>                                                                Honza
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html