linux-ext4 - Re: [PATCH] debugfs: remove unused htree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1105120941170.3752@dhcp-27-109.brq.redhat.com>
Date:	Thu, 12 May 2011 09:43:05 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	Eric Sandeen <sandeen@...hat.com>
cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] debugfs: remove unused htree_dump "-l" argument

On Wed, 11 May 2011, Eric Sandeen wrote:

> The long_opt / -l argument was apparently never implemented,
> so remove it and associated argument parsing.
> 
> This slightly changes the (undocumented) behavior because it
> no longer defaults to cwd if no filespec is specified...

The patch looks good.

Thanks!
-Lukas

> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
> 
> diff --git a/debugfs/htree.c b/debugfs/htree.c
> index 08f9749..b829e25 100644
> --- a/debugfs/htree.c
> +++ b/debugfs/htree.c
> @@ -197,8 +197,6 @@ void do_htree_dump(int argc, char *argv[])
>  {
>  	ext2_ino_t	ino;
>  	struct ext2_inode inode;
> -	int		c;
> -	int		long_opt = 0;
>  	blk64_t		blk;
>  	char		*buf = NULL;
>  	struct 		ext2_dx_root_info  *rootnode;
> @@ -211,28 +209,7 @@ void do_htree_dump(int argc, char *argv[])
>  
>  	pager = open_pager();
>  
> -	reset_getopt();
> -	while ((c = getopt (argc, argv, "l")) != EOF) {
> -		switch (c) {
> -		case 'l':
> -			long_opt++;
> -			break;
> -		default:
> -			goto print_usage;
> -		}
> -	}
> -
> -	if (argc > optind+1) {
> -	print_usage:
> -		com_err(0, 0, "Usage: htree_dump [-l] file");
> -		goto errout;
> -	}
> -
> -	if (argc == optind)
> -		ino = cwd;
> -	else
> -		ino = string_to_inode(argv[optind]);
> -	if (!ino)
> +	if (common_inode_args_process(argc, argv, &ino, 0))
>  		goto errout;
>  
>  	if (debugfs_read_inode(ino, &inode, argv[1]))
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html