linux-ext4 - Re: Regression with ext4 in kernel 2.6.39-rc7? (Was: testing ext4 master branch)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 May 2011 13:16:25 +0300
From:	Amir Goldstein <amir73il@...il.com>
To:	Amir Goldstein <amir73il@...il.com>
Cc:	Ted Ts'o <tytso@....edu>, Eric Sandeen <sandeen@...hat.com>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	Jan Kara <jack@...e.cz>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: Regression with ext4 in kernel 2.6.39-rc7? (Was: testing ext4 master branch)



Sent from my iPhone

On 14/05/2011, at 10:11, Amir Goldstein <amir73il@...il.com> wrote:

> On Sat, May 14, 2011 at 1:49 AM, Ted Ts'o <tytso@....edu> wrote:
>> On Fri, May 13, 2011 at 08:25:02PM +0300, Amir Goldstein wrote:
>>>
>>> After xfstests failed to build on Ubuntu 10.10, I followed the
>>> advice omitted by the build script to run "make install-qa", to
>>> solve the problem.  It took me a while to figure exactly where I
>>> should run the command, but in the end I pulled the xfsprogs tree,
>>> ran "make; make install; make install-qa" and from there on things
>>> were looking better.
>>
>> I did that, but fsstress doesn't pull in the needed xfs/xfs_fs.h
>> header file.  So it still dies.
>>
>>                                                - Ted
>>
>
> Well, anyway, the regression has to be from commit  21f97697:
>
> ext4: remove unnecessary [cm]time update of quota file
>
> because before that commit ext4_quota_off() was too short to
> have a bug at ext4_quota_off+0x42/0xd0.
>
> Jan, where are you? don't make me debug this...

So I guess that Jan's patch is missing
If (!inode)
     goto out;

So much for writing patches from my mobile ;-)

>
> Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html