linux-ext4 - Re: [PATCH] ext4: fix NULL pointer dereference in ext4_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTi=Je5K9vRiiRVF39rZ+xe32QAgRWw@mail.gmail.com>
Date:	Mon, 16 May 2011 17:40:40 +0300
From:	Amir Goldstein <amir73il@...il.com>
To:	"Ted Ts'o" <tytso@....edu>
Cc:	Jan Kara <jack@...e.cz>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: fix NULL pointer dereference in ext4_quota_off

On Mon, May 16, 2011 at 5:04 PM, Ted Ts'o <tytso@....edu> wrote:
> On Mon, May 16, 2011 at 12:11:54PM +0200, Jan Kara wrote:
>>   Ah, I see we worked on the patch together :). Anyway, Ted can pick any of
>> them I guess.
>
> I actually combined the commit description and used elements from both
> of them.  Jan's short description was a better summary, but I liked
> Amir description of the commit (note though that if you're going to
> use abberviated git commit id's, please don't shorten them to 10-12
> characters since given the size of the git repository, shorter git
> commit id's could suffer from hash collision).

Note taken.
I suppose this is not going into 2.6.39(?), so CC: stable is in order.
Thanks,
Amir.

>
>                                                - Ted
>
> ext4: fix oops in ext4_quota_off()
>
> From: Amir Goldstein <amir73il@...il.com>
>
> If quota is not enabled when ext4_quota_off() is called, we must not
> dereference quota file inode since it is NULL.  Check properly for
> this.
>
> This fixes a bug in commit 21f976975cbe (ext4: remove unnecessary
> [cm]time update of quota file), which was merged for 2.6.39-rc3.
>
> Reported-by: Amir Goldstein <amir73il@...rs.sf.net>
> Signed-off-by: Amir Goldstein <amir73il@...rs.sf.net>
> Signed-off-by: Jan Kara <jack@...e.cz>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
>
>                                                - Ted
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html