linux-ext4 - Re: [PATCH 1/3 v2] e2image: Add support for qcow2 format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <25E40602-31D9-4626-BC47-5B52C70C9380@dilger.ca>
Date:	Tue, 17 May 2011 10:01:21 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	Lukas Czerner <lczerner@...hat.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"tytso@....edu" <tytso@....edu>,
	"sandeen@...hat.com" <sandeen@...hat.com>
Subject: Re: [PATCH 1/3 v2] e2image: Add support for qcow2 format

On 2011-05-17, at 5:08 AM, Lukas Czerner <lczerner@...hat.com> wrote:
> On Mon, 16 May 2011, Andreas Dilger wrote:
>> 
>> Because this will be linked into libext2fs, all of these functions should be converted to use the libext2 helper functions for portability reasons.
>> 
>> s/malloc(/,ext2fs_get_mem(/g
>> 
>> though in some places ext2fs_get_array() is preferable, since it does overflow checking.
> 
> I will change malloc to ext2fs_get_mem, but leave calloc as it is since
> it will zero the memory as well unliki ext2fs_get_array().

Please use ext2fs_get_mem() and memset then. I've been thinking for a while to add proper memory accounting to libext2fs for large filesystems. The current use of the system memory accounting will overflow at 32-bit values, so cannot properly account for checking very large filesystems where we already know that e2fsck is allocating more that 4GB. 

Keeping matching ext2_get_mem() and ext2fs_free_mem() is important for a number of reasons. 

Cheers, Andreas--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html