linux-ext4 - Re: [PATCH 1/4] e2fsprogs: Add memory allocation and zero-out helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1105181421240.4100@dhcp-27-109.brq.redhat.com>
Date:	Wed, 18 May 2011 14:22:04 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	Lukas Czerner <lczerner@...hat.com>
cc:	linux-ext4@...r.kernel.org, tytso@....edu, sandeen@...hat.com,
	adilger@...ger.ca
Subject: Re: [PATCH 1/4] e2fsprogs: Add memory allocation and zero-out
 helpers

On Wed, 18 May 2011, Lukas Czerner wrote:

> Add functions ext2fs_get_memzero() which will malloc() the memory
> using ext2fs_get_mem(), but it will zero the allocated memory afterwards
> with memset().
> 
> Add function ext2fs_get_arrayzero() which will use calloc() for
> allocating and zero-out the array.

Sorry this is not right I forgot to commit my changes. Version 2 is out there.

Thanks!
-Lukas

> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> ---
>  lib/ext2fs/ext2fs.h |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/ext2fs/ext2fs.h b/lib/ext2fs/ext2fs.h
> index d3eb31d..4aff26d 100644
> --- a/lib/ext2fs/ext2fs.h
> +++ b/lib/ext2fs/ext2fs.h
> @@ -1404,6 +1404,17 @@ _INLINE_ errcode_t ext2fs_get_memalign(unsigned long size,
>  	return 0;
>  }
>  
> +_INLINE_ errcode_t ext2fs_get_memzero(unsigned long size, void *ptr)
> +{
> +	errcode_t retval;
> +
> +	retval = ext2fs_get_mem(size, ptr);
> +	if (retval)
> +		return retval;
> +	memset(ptr, 0, size);
> +	return 0;
> +}
> +
>  _INLINE_ errcode_t ext2fs_get_array(unsigned long count, unsigned long size, void *ptr)
>  {
>  	if (count && (-1UL)/count<size)
> @@ -1411,6 +1422,19 @@ _INLINE_ errcode_t ext2fs_get_array(unsigned long count, unsigned long size, voi
>  	return ext2fs_get_mem(count*size, ptr);
>  }
>  
> +_INLINE_ errcode_t ext2fs_get_arrayzero(unsigned long count, unsigned long size, void *ptr)
> +{
> +	void *pp;
> +
> +	if (count && (-1UL)/count<size)
> +		return EXT2_ET_NO_MEMORY; //maybe define EXT2_ET_OVERFLOW ?
> +	pp = calloc(count, size);
> +	if (!pp)
> +		return EXT2_ET_NO_MEMORY;
> +	memcpy(ptr, &pp, sizeof (pp));
> +	return 0;
> +}
> +
>  /*
>   * Free memory
>   */
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html