linux-ext4 - Re: [PATCH 1/2] ext3: Add fixed tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1105231804050.3903@dhcp-27-109.brq.redhat.com>
Date:	Mon, 23 May 2011 18:11:54 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	Jan Kara <jack@...e.cz>
cc:	Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] ext3: Add fixed tracepoints

On Mon, 23 May 2011, Jan Kara wrote:

> > @@ -1577,6 +1589,7 @@ static int ext3_ordered_writepage(struct page *page,
> >  	if (ext3_journal_current_handle())
> >  		goto out_fail;
> >  
> > +	trace_ext3_ordered_writepage(inode, page);
> >  	if (!page_has_buffers(page)) {
> >  		create_empty_buffers(page, inode->i_sb->s_blocksize,
> >  				(1 << BH_Dirty)|(1 << BH_Uptodate));
>   Any reason why writepage() takes inode while all other page operations
> take only the page pointer? I see ext4 does this as well but still we don't
> have to be *that* compatible :). Otherwise the patch looks OK.
> 
> 								Honza

Oh, I did not notice that. Thanks, I'll create just one EVENT_CLASS for
page operations.

Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html