[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4DDA9ECA.8000708@redhat.com>
Date: Mon, 23 May 2011 12:52:10 -0500
From: Eric Sandeen <sandeen@...hat.com>
To: ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsck: don't check/clone duplicate xattr blocks in fs
without xattr feature
On 3/9/11 3:01 PM, Eric Sandeen wrote:
> On 2/9/11 12:41 PM, Eric Sandeen wrote:
>> I had an extremely corrupted customer filesystem which, after thousands
>> of lines of e2fsck output, found one more problem on an immediately
>> subsequent e2fsck. In short, a file had had its i_file_acl block
>> cloned due to being a duplicate. That ultimately got cleared
>> because the fs did not have the xattr feature, and the inode
>> was subsequently removed due to invalid mode.
>>
>> The 2nd e2fsck pass found the cloned xattr block as in use, but
>> not owned by any file, and had to fix up the block bitmaps.
>>
>> Simply skipping the processing of duplicate xattr blocks on a
>> non-xattr filesystem seems reasonable, since they will be cleared
>> later in any case.
>>
>> (also fix existing brace misalignment)
>>
>> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
>
> Ted, ping on this one? Would like to get it upstream before
> pushing it to RHEL, because as we all know now, that's how
> we roll at Red Hat. :)
Ping again, for review and/or merge of this one, it's approaching 4 months old now...
Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists