linux-ext4 - Re: [PATCH] ext4: fix unbalanced up_write() in ext4_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110523014303.GG10009@thunk.org>
Date:	Sun, 22 May 2011 21:43:03 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Eric Gouriou <egouriou@...gle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix unbalanced up_write() in ext4_ext_truncate()
 error path

On Tue, May 10, 2011 at 11:12:57AM -0700, Eric Gouriou wrote:
> ext4_ext_truncate() should not invoke up_write(&EXT4_I(inode)->i_data_sem)
> when ext4_orphan_add() returns an error, as it hasn't performed a
> down_write() yet. This trivial patch fixes this by moving the up_write()
> invocation above the out_stop label.
> 
> Signed-off-by: Eric Gouriou <egouriou@...gle.com>

Thanks, applied to the ext4 tree!

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html