linux-ext4 - Re: [PATCH] jbd: Fix comment to match the code in journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 00:28:55 +0200
From:	Jan Kara <jack@...e.cz>
To:	Eryu Guan <guaneryu@...il.com>
Cc:	linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] jbd: Fix comment to match the code in journal_start()

On Tue 24-05-11 00:17:34, Eryu Guan wrote:
> journal_start returns an ERR_PTR() value rather than NULL on failure.
> 
> Cc: Jan Kara <jack@...e.cz>
> Signed-off-by: Eryu Guan <guaneryu@...il.com>
  Tnanks. Merged.

								Honza
> ---
>  fs/jbd/transaction.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 60d2319..f7ee81a 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -266,7 +266,8 @@ static handle_t *new_handle(int nblocks)
>   * This function is visible to journal users (like ext3fs), so is not
>   * called with the journal already locked.
>   *
> - * Return a pointer to a newly allocated handle, or NULL on failure
> + * Return a pointer to a newly allocated handle, or an ERR_PTR() value
> + * on failure.
>   */
>  handle_t *journal_start(journal_t *journal, int nblocks)
>  {
> -- 
> 1.7.3.4
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html