linux-ext4 - Re: [PATCH v4] ext4:Let ext4_ext_fiemap_cb() handle blocks before request range correctly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110524154212.GA26055@thunk.org>
Date:	Tue, 24 May 2011 11:42:12 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	linux-ext4@...r.kernel.org, lczerner@...hat.com, amir73il@...il.com
Subject: Re: [PATCH v4] ext4:Let ext4_ext_fiemap_cb() handle blocks before
 request range correctly.

On Mon, May 23, 2011 at 03:02:58PM +0800, Yongqiang Yang wrote:
> To get delayed-extent information, ext4_ext_fiemap_cb() looks up
> pagecache, it thus collects information starting from a page's
> head block.
> 
> If blocksize < pagesize, the beginning blocks of a page may lies
> before the request range. So ext4_ext_fiemap_cb() should proceed
> ignoring them, because they has been handled before. If no mapped
> buffer in the range is found in the 1st page, we need to look up
> the 2nd page, otherwise delayed-extents after a hole will be ignored.
> 
> Without this patch, xfstests 225 will hung on ext4 with 1K block.
> 
> Reported-by: Amir Goldstein <amir73il@...rs.sourceforge.net>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>

Thanks, added to the ext4 tree.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html