linux-ext4 - Re: [PATCH 14/19] ext3: remove unnecessary dentry_unhash on rmdir/rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 May 2011 10:44:28 +0800
From:	Yongqiang Yang <xiaoqiangnk@...il.com>
To:	Sage Weil <sage@...dream.net>
Cc:	viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org, hch@....de,
	Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 14/19] ext3: remove unnecessary dentry_unhash on rmdir/rename_dir

Hi,

Which kernel version is this patch based on?
Code in my working tree which is 2.6.39-rc3 is already same as the
code after the patch applied.

Thx!

Yongqiang.
On Wed, May 25, 2011 at 4:06 AM, Sage Weil <sage@...dream.net> wrote:
> ext3 has no problems with lingering references to unlinked directory
> inodes.
>
> CC: Jan Kara <jack@...e.cz>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Andreas Dilger <adilger.kernel@...ger.ca>
> CC: linux-ext4@...r.kernel.org
> Signed-off-by: Sage Weil <sage@...dream.net>
> ---
>  fs/ext3/namei.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index f89b1d4..32f3b86 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -2074,8 +2074,6 @@ static int ext3_rmdir (struct inode * dir, struct dentry *dentry)
>        struct ext3_dir_entry_2 * de;
>        handle_t *handle;
>
> -       dentry_unhash(dentry);
> -
>        /* Initialize quotas before so that eventual writes go in
>         * separate transaction */
>        dquot_initialize(dir);
> @@ -2298,9 +2296,6 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry,
>        struct ext3_dir_entry_2 * old_de, * new_de;
>        int retval, flush_file = 0;
>
> -       if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
> -               dentry_unhash(new_dentry);
> -
>        dquot_initialize(old_dir);
>        dquot_initialize(new_dir);
>
> --
> 1.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html