linux-ext4 - Re: [PATCH v2] ext3: Convert ext3 to new truncate calling convention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110527071640.GA5330@infradead.org>
Date:	Fri, 27 May 2011 03:16:40 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jan Kara <jack@...e.cz>
Cc:	Christoph Hellwig <hch@...radead.org>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] ext3: Convert ext3 to new truncate calling convention

On Thu, May 26, 2011 at 04:23:37PM +0200, Jan Kara wrote:
> > This doesn't look quite correct me.  One of the major points of the
> > new truncate sequence is to to *_truncate_page before updating i_size,
> > so that we can properly handle an error there.  With your patch it's
> > still called too late.
>   OK, I missed this point (frankly, handling of error from
> ext3_block_truncate_page() does not seem like a huge win when we cannot
> handle error anywhere else during truncate but it's an improvement I
> agree). I'll move ext3_block_truncate_page() before the setting of i_size.
> Thanks for having a look at the patch.

Btw, I think ext4 has the same issue.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html