linux-ext4 - Re: [PATCH 2/2] jbd: fix a bug of leaking jh->b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110530103201.GB4075@quack.suse.cz>
Date:	Mon, 30 May 2011 12:32:01 +0200
From:	Jan Kara <jack@...e.cz>
To:	Ding Dinghua <dingdinghua@...hpc.ac.cn>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/2] jbd: fix a bug of leaking jh->b_jcount

On Thu 26-05-11 10:29:01, Ding Dinghua wrote:
> journal_get_create_access should drop jh->b_jcount in error handling path
> 
> Signed-off-by: Ding Dinghua <dingdinghua@...hpc.ac.cn>
  Thanks. Merged into my tree.


								Honza
> ---
>  fs/jbd/transaction.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index f7ee81a..3b3b01f 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -844,8 +844,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
>  	 */
>  	JBUFFER_TRACE(jh, "cancelling revoke");
>  	journal_cancel_revoke(handle, jh);
> -	journal_put_journal_head(jh);
>  out:
> +	journal_put_journal_head(jh);
>  	return err;
>  }
>  
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html