linux-ext4 - Re: [PATCH] xfstests: add support for ext4dev FSTYP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DE5CC8E.1090208@redhat.com>
Date:	Wed, 01 Jun 2011 00:22:22 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Amir Goldstein <amir73il@...il.com>
CC:	XFS <xfs@....sgi.com>, Sergey Ivanov <sergey57@...il.com>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] xfstests: add support for ext4dev FSTYP

On 5/31/11 11:56 PM, Amir Goldstein wrote:
> On Wed, Jun 1, 2011 at 7:37 AM, Eric Sandeen <sandeen@...hat.com> wrote:
>> On 5/31/11 10:13 PM, Amir Goldstein wrote:
>>> From: Amir Goldstein <amir73il@...rs.sf.net>
>>>
>>> blkid knows to identify the ext4dev FSTYP of a partition that was
>>> formatted with mkfs.ext4dev.
>>> quota tools and various util-linux utils are also aware of ext4dev,
>>> so ext4dev shares the same capabilities as ext4.
>>>
>>> While testing on Fedora 15, we encoutered a buggy fsck utility, which
>>> invokes fsck.ext4, even though it was called with -t ext4dev argument.
>>> In our setup fsck.ext4dev knows about new fs features that fsck.ext4
>>> doesn't know, so the generic_fs_check fails.
>>> Since we have no real use of the extra capabilities provided by fsck util,
>>> we decided to invoke fsck.$FSTYP directly to avoid this issue.
>>
>> Adding ext4dev to every case seems harmless enough.  TBH I thought I had
>> it there already but I guess not.
>>
>> I'm less certain of the change from fsck -t $FSTYP to fsck.$FSTYP
>>
>> What issue are you avoiding?  wouldn't fsck -t ext4dev invoke fsck.ext4dev anyway?
>>
>> It seems like it should be harmless, but I don't understand how it helps you.
>>
> 
> As I wrote in the patch description, the fsck utility in Fedora 15 invokes
> fsck.ext4 for some reason when calling fsck -t ext4dev.

Oh, right.

> this fails because fsck.ext4 doesn't know the snapshot feature.
> I didn't debug fsck utility for that. it seemed pointless.

Did you file a bug with Fedora?  I'd rather fix the root cause than work around it...
Feel free to cc: me on the bug.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html