linux-ext4 - Re: [PATCH v2] ext3: use proper little-endian bitops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110602165347.GB13668@quack.suse.cz>
Date:	Thu, 2 Jun 2011 18:53:47 +0200
From:	Jan Kara <jack@...e.cz>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] ext3: use proper little-endian bitops

On Wed 01-06-11 23:34:04, Akinobu Mita wrote:
> ext3_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le()
> for ext3.  But all ext3_{set,clear}_bit() calls ignore return values.
> So these can be replaced with __{set,clear}_bit_le().
> 
> This changes ext3_{set,clear}_bit safely, because if someone uses
> these macros without noticing the change, new ext3_{set,clear}_bit
> don't have return value and causes compiler errors where the return
> value is used.
> 
> This also removes unused ext3_find_first_zero_bit().
  Thanks. Merged.

								Honza
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> Cc: linux-ext4@...r.kernel.org
> ---
> v2: rewritten to keep ext3_*_bit() macros
> 
>  include/linux/ext3_fs.h |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h
> index 5e06acf..50f21ee 100644
> --- a/include/linux/ext3_fs.h
> +++ b/include/linux/ext3_fs.h
> @@ -418,12 +418,11 @@ struct ext3_inode {
>  #define EXT2_MOUNT_DATA_FLAGS		EXT3_MOUNT_DATA_FLAGS
>  #endif
>  
> -#define ext3_set_bit			__test_and_set_bit_le
> +#define ext3_set_bit			__set_bit_le
>  #define ext3_set_bit_atomic		ext2_set_bit_atomic
> -#define ext3_clear_bit			__test_and_clear_bit_le
> +#define ext3_clear_bit			__clear_bit_le
>  #define ext3_clear_bit_atomic		ext2_clear_bit_atomic
>  #define ext3_test_bit			test_bit_le
> -#define ext3_find_first_zero_bit	find_first_zero_bit_le
>  #define ext3_find_next_zero_bit		find_next_zero_bit_le
>  
>  /*
> -- 
> 1.7.4.4
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html