linux-ext4 - Re: [PATCH] jbd: Use WRITE_SYNC in journal checkpoint.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608155048.GD5361@quack.suse.cz>
Date:	Wed, 8 Jun 2011 17:50:48 +0200
From:	Jan Kara <jack@...e.cz>
To:	Tao Ma <tm@....ma>
Cc:	linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>, tytso@....edu
Subject: Re: [PATCH] jbd: Use WRITE_SYNC in journal checkpoint.

On Tue 07-06-11 11:56:50, Tao Ma wrote:
> From: Tao Ma <boyu.mt@...bao.com>
> 
> In journal checkpoint, we write the buffer and wait for its finish.
> But in cfq, the async queue has a very low priority, and in our test,
> if there are too many sync queues and every queue is filled up with
> requests, and the process will hang waiting for the log space.
> 
> So this patch tries to use WRITE_SYNC in __flush_batch so that the request will
> be moved into sync queue and handled by cfq timely. We also use the new plug,
> sot that all the WRITE_SYNC requests can be given as a whole when we unplug it.
  OK, makes sense to me. I'd like to merge the patch but I'd also like to
keep compatibility with ext4 here so I'll wait for a while what Ted thinks
about this change... Ted?

								Honza
> 
> Cc: Jan Kara <jack@...e.cz>
> Reported-by: Robin Dong <sanbai@...bao.com>
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
> ---
>  fs/jbd/checkpoint.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jbd/checkpoint.c b/fs/jbd/checkpoint.c
> index e4b87bc..a7ce053 100644
> --- a/fs/jbd/checkpoint.c
> +++ b/fs/jbd/checkpoint.c
> @@ -22,6 +22,7 @@
>  #include <linux/jbd.h>
>  #include <linux/errno.h>
>  #include <linux/slab.h>
> +#include <linux/blkdev.h>
>  
>  /*
>   * Unlink a buffer from a transaction checkpoint list.
> @@ -253,9 +254,12 @@ static void
>  __flush_batch(journal_t *journal, struct buffer_head **bhs, int *batch_count)
>  {
>  	int i;
> +	struct blk_plug plug;
>  
> +	blk_start_plug(&plug);
>  	for (i = 0; i < *batch_count; i++)
> -		write_dirty_buffer(bhs[i], WRITE);
> +		write_dirty_buffer(bhs[i], WRITE_SYNC);
> +	blk_finish_plug(&plug);
>  
>  	for (i = 0; i < *batch_count; i++) {
>  		struct buffer_head *bh = bhs[i];
> -- 
> 1.7.4
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html