linux-ext4 - Re: [PATCH] mke2fs: check that auto-detected blocksize <= sys_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikGv=OZgV0iwZroDDnPi+TiyxDzVg@mail.gmail.com>
Date:	Wed, 8 Jun 2011 15:50:10 +0300
From:	Amir Goldstein <amir73il@...il.com>
To:	"Yury V. Zaytsev" <yury@...rup.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] mke2fs: check that auto-detected blocksize <= sys_page_size

On Wed, Jun 8, 2011 at 12:23 PM, Yury V. Zaytsev <yury@...rup.com> wrote:
> Hi!
>
> I have recently stumbled upon a RHEL6.1 installation problem on an SSD
> drive that was working fine with older kernels, where created file
> systems could not be mounted and the installation was aborting.
>
> It turned out that the drive had a firmware bug and was exposing a
> minimum_io_size of 8912, whereas my x86_64 system had a page size of
> 4096 bytes.
>
> mkfs in turn was silently creating file systems with 8912 bytes block
> size, because it was auto-detected as opposed to specified via the -b
> option from the command line.
>
> This made the problem hard to debug, hence I attach a tentative patch to
> fix this issue. I'd like to acknowledge Mike Snitzer for directing me to
> this list.
>
> I'm not subscribed, so please CC: me upon replies and be mindful that
> it's my first contribution of this kind, so even though I did my best to
> do it the right way, I might have screwed something up.

The only thing you screwed up is sending the patch as an attachment.
People here expect it to be as plain text in the email, so that they can
reply and comment inline.
Other than that, the fix looks good (and well explained) to me.

Cheers,
Amir.

>
> Thanks!
>
> --
> Sincerely yours,
> Yury V. Zaytsev
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html