[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1307685770-6099-1-git-send-email-adilger@whamcloud.com>
Date: Fri, 10 Jun 2011 00:02:50 -0600
From: Andreas Dilger <adilger@...mcloud.com>
To: tytso@....edu, linux-ext4@...r.kernel.org
Cc: Andreas Dilger <adilger@...mcloud.com>
Subject: [PATCH] debugfs: fix icheck finding blocks used for xattrs
This was an "uninitialized variable" warning, but it turns out to be
a real bug. Without this change, it is not possible to use "icheck"
to find blocks that are used for the i_file_acl (xattr) block.
Signed-off-by: Andreas Dilger <adilger@...mcloud.com>
---
debugfs/icheck.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/debugfs/icheck.c b/debugfs/icheck.c
index 643bc5b..729ac93 100644
--- a/debugfs/icheck.c
+++ b/debugfs/icheck.c
@@ -106,13 +106,15 @@ void do_icheck(int argc, char **argv)
}
while (ino) {
+ blk64_t blk;
+
if (!inode.i_links_count)
goto next;
bw.inode = ino;
- if (ext2fs_file_acl_block(&inode)) {
- blk64_t blk;
+ blk = ext2fs_file_acl_block(&inode);
+ if (blk) {
icheck_proc(current_fs, &blk, 0,
0, 0, &bw);
if (bw.blocks_left == 0)
--
1.7.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists